build(dvb-si-py): declare its own workspace root (closes #720 — bindings already current) - #834
Merged
Merged
Conversation
bindings/python lacked the `[workspace]` stanza its sibling transmux-py carries. The root manifest's `exclude` keeps it out of the member glob but does not stop cargo walking up, so any cargo invocation from inside a nested git worktree adopted the repo workspace and failed with "current package believes it's in a workspace when it's not". Verified by removing the stanza again: `cargo metadata` fails without it and succeeds with it. Refs #720
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#720 was stale — verified, not assumed
Both bindings already track the current published crates, so the rename ripple the issue anticipated had already landed:
bindings/transmux-pytransmux = "0.20"bindings/pythondvb-si = "9",dvb-t2mi = "9"Verified end to end rather than by reading the manifests:
maturin build --release --lockedproducestransmux_py-0.1.0-cp39-abi3-macosx_11_0_arm64.whl.pytest tests -q→ 4 passed.fixtures/ts/h264_aac.tsand assert the oracle-backed counts (75 video / 131 audio samples), 90 kHz / 44.1 kHz timescales, 320x240, an RFC 6381avc1.string, and non-empty sample bytes with the first sample flagged sync.The one real defect found
bindings/python/Cargo.tomllacked the[workspace]stanza its siblingtransmux-pycarries. The root manifest'sexcludekeeps it out of the member glob but does not stop cargo walking up, so any cargo invocation from inside a nested git worktree adopted the repo workspace and failed:Proven to bite: with the stanza removed again
cargo metadatafails as above; with it, it resolves. That asymmetry between the two sibling bindings was the actual bug behind the issue's suspicion.Closes #720