add missing chargeitemflags to ifPos/v2#104
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the fiskaltrust.ifPOS v2 case-flag surface area by adding missing ChargeItemCaseFlags entries so integrators can represent Downpayment, ReturnableDeposit, and TakeAway scenarios on ChargeItemCase values.
Changes:
- Added
Downpaymentflag toChargeItemCaseFlags(0x0000_0000_0008_0000). - Added
ReturnableDepositflag toChargeItemCaseFlags(0x0000_0000_0010_0000). - Added
TakeAwayflag toChargeItemCaseFlags(0x0000_0000_0020_0000).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
volllly
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR updates the
fiskaltrust.ifPOSv2 case-flag surface area by adding missingChargeItemCaseFlagsentries so integrators can represent Downpayment, ReturnableDeposit, and TakeAway scenarios onChargeItemCasevalues.Changes:
Downpaymentflag toChargeItemCaseFlags(0x0000_0000_0008_0000).ReturnableDepositflag toChargeItemCaseFlags(0x0000_0000_0010_0000).TakeAwayflag toChargeItemCaseFlags(0x0000_0000_0020_0000).Fixes #{issue 167}