chore: remove unused serviceConfig option - #289
Merged
Conversation
serviceConfig was threaded through the CLI/core/service pipeline but never read by any of the remaining services (agent, sync-without-translate, key-as-translation) since the v3 purge of API-based translation services. Also moves --service=agent to the end of the prompt example commands in README.md and README-es.md for consistency with other examples. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
--matcher masked interpolation placeholders (icu/sprintf/i18next) as XML tags before sending strings to a translation service, then reinserted them afterward. This was designed to protect placeholders from being mangled by dumb machine-translation APIs — a concern that no longer applies now that "agent" (an LLM) is the only service that transforms text, and the other two services (sync-without-translate, key-as-translation) never look at the string content at all. It was also undocumented in both READMEs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serviceConfig was threaded through the CLI/core/service pipeline but never read by any of the remaining services (agent, sync-without-translate, key-as-translation) since the v3 purge of API-based translation services.