Skip to content

Enhance get_translations() to optionally return full contents #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StasNemy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance get_translations() to optionally return full contents #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e83783
Enhance get_translations() to optionally return full contents
StasNemy May 29, 2025
83134a2
Refactor get_translations() to return a list of terms instead of yiel…
StasNemy May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions reverso_context_api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,25 @@ def __init__(self, source_lang, target_lang, credentials=None, user_agent=None):
self._source_lang, self._target_lang = source_lang, target_lang
self._session = ReversoSession(credentials=credentials, user_agent=user_agent)

def get_translations(self, text, source_lang=None, target_lang=None):
"""Yields found translations of word (without context)
def get_translations(self, text, source_lang=None, target_lang=None, return_contents=False):
"""Yields found translations of word (without context) or returns the full contents if `return_contents` is True.
For example:
>>> list(Client("de", "en").get_translations("braucht"))
['needed', 'required', 'need', 'takes', 'requires', 'take', 'necessary'...]
>>> contents = Client("de", "en").get_translations("braucht", return_contents=True)
>>> contents["dictionary_entry_list"]
[{'term': 'needed'}, {'term': 'required'}, {'term': 'need'}, ...]

:param return_contents: If True, returns the full contents instead of yielding translations.
"""
r = self._request_translations(text, source_lang, target_lang)

contents = r.json()
for entry in contents["dictionary_entry_list"]:
yield entry["term"]

if return_contents == True:
return contents

return [entry["term"] for entry in contents["dictionary_entry_list"]]


def get_translation_samples(self, text, target_text=None, source_lang=None, target_lang=None, cleanup=True):
"""Yields pairs (source_text, translation) of context for passed text
Expand Down