feat(packaging): introduce RPM builds and unified changelog management#388
Closed
shiptux wants to merge 1 commit into
Closed
feat(packaging): introduce RPM builds and unified changelog management#388shiptux wants to merge 1 commit into
shiptux wants to merge 1 commit into
Conversation
Implement comprehensive RPM package building support: - Add new `.github/workflows/build-rpm.yml` for CI/CD. - Introduce `packaging/rpm/build-flagcx-rpm.sh` script for local and CI builds. - Include backend-specific Dockerfiles (`Dockerfile.nvidia`, `Dockerfile.ascend`) and an RPM spec file (`flagcx.spec`). Integrate Ascend backend support across packaging: - Extend Debian packaging (`.github/workflows/build-deb.yml`, `packaging/debian/control`, `packaging/debian/rules`) to include Ascend. - Enable Ascend backend for RPM builds. Establish a unified changelog management system: - `docs/CHANGELOG.md` becomes the single source of truth for release history. - Add `packaging/sync-changelog.py` to automatically convert `docs/CHANGELOG.md` to Debian and RPM changelog formats. - Integrate the sync script into both Debian and RPM build workflows and local build scripts. - Document the new process in `packaging/CHANGELOG-MANAGEMENT.md`. Other related changes: - Update `.gitignore` to include `rpm-packages`. - Enhance `packaging/README.md` with details on RPM building, supported architectures, and changelog management.
SamYuan1990
reviewed
Feb 24, 2026
| $(MAKE) clean || true | ||
|
|
||
| override_dh_auto_build: | ||
| ifeq ($(FLAGCX_BUILD_BACKEND),nvidia) |
Contributor
There was a problem hiding this comment.
can we try a switch instead of if else here?
Contributor
Author
There was a problem hiding this comment.
maybe we can create a new pr to do this
SamYuan1990
suggested changes
Feb 24, 2026
Contributor
SamYuan1990
left a comment
SamYuan1990
left a comment
There was a problem hiding this comment.
@shiptux , I will ask you spilt this PR into 3 different things, currently which is too feat.
- ascend support
- rpm
- some components enhancement for deb build (for example you have change log collection for deb, how about RPM?)
SamYuan1990
reviewed
Feb 24, 2026
| # Sync changelog from CHANGELOG.md | ||
| log_step "Synchronizing changelog..." | ||
| if [ -f "${PROJECT_DIR}/packaging/sync-changelog.py" ]; then | ||
| python3 "${PROJECT_DIR}/packaging/sync-changelog.py" || log_warn "Failed to sync changelog" |
Contributor
There was a problem hiding this comment.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
CICD
PR Types
Optimizations
PR Description
Implement comprehensive RPM package building support:
.github/workflows/build-rpm.ymlfor CI/CD.packaging/rpm/build-flagcx-rpm.shscript for local and CI builds.Dockerfile.nvidia,Dockerfile.ascend) and an RPM spec file (flagcx.spec).Integrate Ascend backend support across packaging:
.github/workflows/build-deb.yml,packaging/debian/control,packaging/debian/rules) to include Ascend.Establish a unified changelog management system:
docs/CHANGELOG.mdbecomes the single source of truth for release history.packaging/sync-changelog.pyto automatically convertdocs/CHANGELOG.mdto Debian and RPM changelog formats.packaging/CHANGELOG-MANAGEMENT.md.Other related changes:
.gitignoreto includerpm-packages.packaging/README.mdwith details on RPM building, supported architectures, and changelog management.