Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 GPT-6.1-Sol on behalf of Oliver
The dashboard migration needs tests that verify chart values and interactions without depending on canvas pixels. This layer expands the normal SQLite fixture and establishes a DOM contract that the TanStack/SVG renderer must retain.
Layer 2 of the frontend overhaul, based on
perf/harnessfrom #129. Nothing is merged or deployed by this layer.Coverage
The read-only real-data QA recorded 280 actions across the baseline and follow-up scripts and saved 78 before screenshots. Artifacts remain local in
/tmp/atlantis-frontend-overhaul/e2e/:flows.md,findings.md,chart-contract.md,screens.md, audit JSON/scripts andbaseline-screens/. Private dataset screenshots were not uploaded. The perf stage, test stage, Cloudflare and v5 database were unchanged. The perf benchmark was not rerun and this PR makes no performance improvement claim.Renderer contract
The e2e README spells out the migration contract. Preserve
data-chart-id,data-chart-activated,data-chart-sentinel, and the following hooks:chart-surfacewithrole="img", accessible name/description anddata-chart-rendered.chart-render-statewith state, kind, finite positioned mark count and visible series count.chart-serieswith label, visibility, count/min/max/total and normalized point/legend interaction targets;chart-axiswith displayed axis titles.chart-tooltipwith the displayed tooltip text; existing spectrumrole="tooltip".chart-card-stateand coverage lifecycle state.The publisher is renderer independent and accepts HTML or SVG. The temporary Chart.js adapter publishes after rendering and removes summaries on destruction. Unknown coverage and unpositioned/nonfinite points do not count as rendered marks. Coverage summaries describe observed/expected ratios. This adds accessible summaries, not keyboard chart navigation.
Top QA findings for later layers
No product bugs were fixed here. The known DST capture-evidence issue #104 remains separate.
Human review guide
bun run test:e2ewith the normal fixture server. It should pass without access to the private product or perf deployment.Automated verification passed:
bun run format,bun run lint,bun run typecheck,bun run test:webwith 215 tests, andbun run test:e2ewith 57 tests. Manual Chromium QA covered 320/390/1440/1920px views. Full screen-reader/contrast review, touch devices, Firefox/WebKit and performance remeasurement remain for later layers.Made by GPT-6.1-Sol through the Codex harness in T3 Code.