Repository navigation
fix(service-manager): CU-17tkuw5ww5h: stop logging the openframe secret - #178
Merged
danylo-babenko-flamingo merged 2 commits intoOct 15, 2026
Merged
Conversation
danylo-babenko-flamingo
force-pushed
the
fix/stop-logging-openframe-secret
branch
from
October 13, 2026 18:04
ae527a7 to
e5f20e5
Compare
🦩 Flamingo Code ReviewNot reviewed yet. Reviews start when you ask, so the reviewer reads this pull request when it is ready, not when it is opened. When it is ready:
Or comment Updated 2026-10-13 18:04 UTC · workflow run |
denys-gif
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stops the mesh agent from printing
--openframe-secretto stdout. The OpenFrame client logs that output, so the secret ended up in device logs, Loki and Mingo answers.Improvements
modules/service-manager.js: removed the two macOS[DEBUG service-manager]parameter prints and theparameters =>/options =>prints indaemon().microscript/ILibDuktape_Polyfills.c: embeddedservice-managerregenerated from the current embedded copy minus the same lines (the unembedded keepAlive change from 7f2ad09 is not included).Change-Set: fix-stop-logging-openframe-secret
Task
CU-17tkuw5x3yh
Change set
flamingo-stack/fix-stop-logging-openframe-secret: these pull requests are one change, reviewed together.Linked work
Linked by the
Depends-On/Change-Setlines in these descriptions; this block is maintained by the hub.