Skip to content

fix(service-manager): CU-17tkuw5ww5h: stop logging the openframe secret - #178

Merged
danylo-babenko-flamingo merged 2 commits into
masterfrom
fix/stop-logging-openframe-secret
Oct 15, 2026
Merged

danylo-babenko-flamingo merged 2 commits into
masterfrom
fix/stop-logging-openframe-secret

Conversation

@danylo-babenko-flamingo

@danylo-babenko-flamingo danylo-babenko-flamingo commented Oct 13, 2026 •

Copy link
Copy Markdown

Description

Stops the mesh agent from printing --openframe-secret to stdout. The OpenFrame client logs that output, so the secret ended up in device logs, Loki and Mingo answers.

Improvements

  • modules/service-manager.js: removed the two macOS [DEBUG service-manager] parameter prints and the parameters => / options => prints in daemon().
  • microscript/ILibDuktape_Polyfills.c: embedded service-manager regenerated from the current embedded copy minus the same lines (the unembedded keepAlive change from 7f2ad09 is not included).
  • No behavior change.

Change-Set: fix-stop-logging-openframe-secret

Task

CU-17tkuw5x3yh

Change set flamingo-stack/fix-stop-logging-openframe-secret: these pull requests are one change, reviewed together.

Linked work

  • …and 2 linked items not shown here

Linked by the Depends-On / Change-Set lines in these descriptions; this block is maintained by the hub.

@danylo-babenko-flamingo
danylo-babenko-flamingo force-pushed the fix/stop-logging-openframe-secret branch from ae527a7 to e5f20e5 Compare October 13, 2026 18:04
@github-actions

Copy link
Copy Markdown

🦩 Flamingo Code Review

Not reviewed yet. Reviews start when you ask, so the reviewer reads this pull request when it is ready, not when it is opened.

When it is ready:

  • Review this pull request

Or comment @flamingo-review. Add the flamingo-review-always label to review every push.

Updated 2026-10-13 18:04 UTC · workflow run

@danylo-babenko-flamingo
danylo-babenko-flamingo merged commit b2b59a9 into master Oct 15, 2026
18 checks passed
@danylo-babenko-flamingo
danylo-babenko-flamingo deleted the fix/stop-logging-openframe-secret branch October 15, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants