Repository navigation
fix(OPENFRAM-004): CU-86aknprf9 runDeleteCluster returns a raw wrapped error instead of the AlreadyHandledError sentinel - #404
Draft
flamingo[bot] wants to merge 1 commit into
Conversation
…ad of the AlreadyHandledError sentinel
| @@ -100,7 +100,7 @@ func runDeleteCluster(cmd *cobra.Command, args []string) error { | |||
| clusterType, err := service.DetectClusterType(clusterName) | |||
Contributor
Author
There was a problem hiding this comment.
🦩 🔴 runDeleteCluster returns a raw wrapped error instead of the AlreadyHandledError sentinel
In runDeleteCluster (cmd/cluster/delete.go), the DetectClusterType error branch now wraps its returned error through sharedErrors.HandleGlobalError(fmt.Errorf(...), globalFlags.Global.Verbose) instead of returning the bare fmt.Errorf-wrapped error, matching the pattern used elsewhere in the same function so main's errors.As sentinel check behaves uniformly and the error isn't printed twice.
🤖 Prompt for AI agents
In cmd/cluster/delete.go around line 100, review and complete this code-review fix: runDeleteCluster returns a raw wrapped error instead of the AlreadyHandledError sentinel.
What the draft fix changed: In runDeleteCluster (cmd/cluster/delete.go), the DetectClusterType error branch now wraps its returned error through sharedErrors.HandleGlobalError(fmt.Errorf(...), globalFlags.Global.Verbose) instead of returning the bare fmt.Errorf-wrapped error, matching the pattern used elsewhere in the same function so main's errors.As sentinel check behaves uniformly and the error isn't printed twice.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule OPENFRAM-004 — runDeleteCluster returns a raw wrapped error instead of the AlreadyHandledError sentinel.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
cmd/cluster/delete.go:100What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
f7e219df-eddc-4e74-8a53-72d2cf9000c3Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86aknprf9 OpenFrame CLI code duplication and manager fixes (13 PRs)