Repository navigation
fix(OSQUERY-010-2): CU-17tkuw5wp49 kafka_producer.cpp uses _WIN32 instead of the canonical WIN32 guard - #116
Draft
flamingo[bot] wants to merge 1 commit into
Draft
flamingo[bot] wants to merge 1 commit into
flamingo[bot] wants to merge 1 commit into
Conversation
…onical WIN32 guard
| #include <osquery/remote/transports/tls.h> | ||
| // clang-format on | ||
|
|
||
| #ifdef _WIN32 |
Author
There was a problem hiding this comment.
🦩 🟠 kafka_producer.cpp uses _WIN32 instead of the canonical WIN32 guard
Changed the platform guard in the top-of-file include block from #ifdef _WIN32 / #elif defined _unix_ to #ifdef WIN32 / #else, matching the canonical OSQUERY-010-2 WIN32 guard and ensuring <unistd.h> is included on all non-Windows builds instead of only on a never-defined _unix_ macro.
🤖 Prompt for AI agents
In plugins/logger/kafka_producer.cpp around line 17, review and complete this code-review fix: kafka_producer.cpp uses _WIN32 instead of the canonical WIN32 guard.
What the draft fix changed: Changed the platform guard in the top-of-file include block from `#ifdef _WIN32` / `#elif defined _unix_` to `#ifdef WIN32` / `#else`, matching the canonical OSQUERY-010-2 `WIN32` guard and ensuring `<unistd.h>` is included on all non-Windows builds instead of only on a never-defined `_unix_` macro.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule OSQUERY-010-2 — kafka_producer.cpp uses _WIN32 instead of the canonical WIN32 guard.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
plugins/logger/kafka_producer.cpp:17What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
cb1fa104-eac6-46a7-aba8-90d794c59386Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-17tkuw5wp49 Osquery review findings sweep (8 PRs)