Windows: fixes · Pull Request #282 · flang-compiler/flang

ghost · 2017-10-20T17:14:23Z

Attached are some fixes for the windows functions.

ghost · 2017-10-20T20:17:25Z

I don't think there's been a single contributor pull request accepted, looking at the history.

@sscalpone Are you going to merge (not now, but eventually) this or was this a waste of time?

sscalpone · 2017-10-20T20:54:24Z

A few contributor requests have been merged for README.md and CMakefile.txt files. Flang needs to have a CLA for source-file changes. We are working to create this CLA now. We will review on flang-dev list soon.

Windows Fixes

WIP Windows

ghost · 2017-10-22T00:12:59Z

I should mention that the timing functions don't actually work; I'm not sure what they're for.

ghost · 2017-10-24T00:03:33Z

You might or might not need _fileno. Not sure what the type of that struct is.

More windows fixes

sscalpone · 2017-10-24T00:48:09Z

We haven't pushed out Windows implementation files to github yet. I'm working on a pull request to get the windows sources into the repo. With hope, they'll start showing up tomorrow (Tuesday) to support your efforts. Do you have changes for flang-compiler/clang too?

ghost · 2017-10-24T00:52:25Z

No. Changes were not required there. I implemented some of the functions in a "quick" (eg. nonworking) way just to get the compilation going. Then I triaged those functions so that I could come back to them later (#285, #283).

@isuruf Had to fix CMake so that it would call the linker correctly.

I really wish for the CLA so that there's no duplication of work.

ghost · 2017-10-24T00:53:34Z

Also, would highly recommend merging #284. We spent some time on that.

ghost

A few comments.

ghost · 2017-10-24T01:34:37Z

    __fort_rrecv(ioproc, &off, sizeof(off), 1, __UCHAR);
  } else {
    off = 0;
-    fd = open(path, O_WRONLY | O_CREAT | O_TRUNC, 0666);


Should be open(path, O_WRONLY | O_CREAT | O_TRUNC);.

ghost · 2017-10-24T01:37:49Z

  strcpy(host, p);
+#else
+  strcpy(host, "localhost");
+#endif	  


Should be

#include <Winsock2.h> char host[128] = ""; gethostname(host, sizeof(host));

isuruf · 2017-10-24T14:16:50Z

If anybody is interested, here's the status now.

[ 69%] Linking Fortran shared library ..\..\bin\flang.dll
LINK: command "C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\link.exe /nologo @CMakeFiles\flang_shared.dir\objects1.rsp /out:..\..\bin\flang.dll /implib:..\..\lib\flang.lib /pdb:C:\Users\idf2\flang\build3\bin\flang.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO /DEF:CMakeFiles\flang_shared.dir\exports.def -LIBPATH:C:\Users\idf2\miniconda3\Library\lib ..\..\lib\flangrti.lib libomp.lib /MANIFEST /MANIFESTFILE:..\..\bin\flang.dll.manifest" failed (exit code 1120) with the following output:
etime3f.c.obj : error LNK2005: convert_filetime already defined in dtime3f.c.obj
etime3f.c.obj : error LNK2005: dtime_ already defined in dtime3f.c.obj
cvt.c.obj : warning LNK4197: export 'ecvt' specified multiple times; using first specification
cvt.c.obj : warning LNK4197: export 'fcvt' specified multiple times; using first specification
   Creating library ..\..\lib\flang.lib and object ..\..\lib\flang.exp
amod.c.obj : error LNK2019: unresolved external symbol __fmth_i_amod referenced in function __mth_i_amod
cdcos.c.obj : error LNK2019: unresolved external symbol sincos referenced in function __mth_i_cdcos
cdexp.c.obj : error LNK2001: unresolved external symbol sincos
cexp.c.obj : error LNK2019: unresolved external symbol sincosf referenced in function __mth_i_cexp
dmod.c.obj : error LNK2019: unresolved external symbol __fmth_i_dmod referenced in function __mth_i_dmod
fsync3f.c.obj : error LNK2019: unresolved external symbol fsync referenced in function fsync_
irandm3f.c.obj : error LNK2019: unresolved external symbol srand48 referenced in function irandm_
irandm3f.c.obj : error LNK2019: unresolved external symbol lrand48 referenced in function irandm_
xfer_heap_dum.c.obj : error LNK2019: unresolved external symbol sbrk referenced in function __fort_sbrk
nmlwrite.c.obj : error LNK2001: unresolved external symbol __fortio_binary_mode
rewind.c.obj : error LNK2001: unresolved external symbol __fortio_binary_mode
backspace.c.obj : error LNK2001: unresolved external symbol __fortio_binary_mode
close.c.obj : error LNK2001: unresolved external symbol __fortio_binary_mode
fmtwrite.c.obj : error LNK2001: unresolved external symbol __fortio_binary_mode
ldwrite.c.obj : error LNK2001: unresolved external symbol __fortio_binary_mode
miscsup_com.c.obj : error LNK2019: unresolved external symbol gettimeofday referenced in function fort_dandt
type.c.obj : error LNK2019: unresolved external symbol __get_fort_size_of referenced in function f90_poly_asn
utils.c.obj : error LNK2019: unresolved external symbol ftruncate referenced in function __fortio_rwinit
init.c.obj : error LNK2019: unresolved external symbol __fort_sethand referenced in function __fort_begpar
..\..\bin\flang.dll : fatal error LNK1120: 13 unresolved externals

ghost · 2017-10-24T15:38:01Z

@isuruf did you add my __fortio_binary_mode?

ghost · 2017-10-24T15:42:35Z

Also, gettimeofday is at microsoft/vcpkg#1991.

isuruf · 2017-10-25T00:42:39Z

@isuruf did you add my __fortio_binary_mode?

No, I didn't. I'll do that once I get some time.

ghost · 2017-10-25T01:12:08Z

One more interesting bit is that there shouldn't be an ifdef here:

flang/runtime/flang/amod.c

Line 28 in bd6802a

return __fmth_i_amod(f, g);

ghost · 2017-10-25T01:12:40Z

It should be

float
__mth_i_amod(float f, float g)
{
  return FMODF(f, g);
}

ghost · 2017-10-25T01:17:08Z

sincos:

extern void sincos(double x, double *sine, double *cosine) {
    sine = sin(x);
    cosine = cos(x);
}

ghost · 2017-10-25T01:29:14Z

Actually the sbrk implementation is a bit trickier. I've opened emeryberger/Malloc-Implementations#1 to attempt to obtain a legally-compatible implementation in a time-efficient way. I currently don't have time to re-implement a memory allocator.

isuruf · 2017-10-25T03:49:17Z

I've pushed some fixes to my branch and the errors now are,

[ 69%] Linking Fortran shared library ..\..\bin\flang.dll
LINK: command "C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\link.exe /nologo @CMakeFiles\flang_shared.dir\objects1.rsp /out:..\..\bin\flang.dll /implib:..\..\lib\flang.lib /pdb:C:\Users\idf2\flang\build3\bin\flang.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO /DEF:CMakeFiles\flang_shared.dir\exports.def -LIBPATH:C:\Users\idf2\miniconda3\Library\lib ..\..\lib\flangrti.lib libomp.lib /MANIFEST /MANIFESTFILE:..\..\bin\flang.dll.manifest" failed (exit code 1120) with the following output:
etime3f.c.obj : error LNK2005: convert_filetime already defined in dtime3f.c.obj
etime3f.c.obj : error LNK2005: dtime_ already defined in dtime3f.c.obj
cvt.c.obj : warning LNK4197: export 'ecvt' specified multiple times; using first specification
cvt.c.obj : warning LNK4197: export 'fcvt' specified multiple times; using first specification
   Creating library ..\..\lib\flang.lib and object ..\..\lib\flang.exp
dmod.c.obj : error LNK2019: unresolved external symbol __fmth_i_dmod referenced in function __mth_i_dmod
fsync3f.c.obj : error LNK2019: unresolved external symbol fsync referenced in function fsync_
irandm3f.c.obj : error LNK2019: unresolved external symbol srand48 referenced in function irandm_
irandm3f.c.obj : error LNK2019: unresolved external symbol lrand48 referenced in function irandm_
xfer_heap_dum.c.obj : error LNK2019: unresolved external symbol sbrk referenced in function __fort_sbrk
type.c.obj : error LNK2019: unresolved external symbol __get_fort_size_of referenced in function f90_poly_asn
utils.c.obj : error LNK2019: unresolved external symbol ftruncate referenced in function __fortio_rwinit
init.c.obj : error LNK2019: unresolved external symbol __fort_sethand referenced in function __fort_begpar
..\..\bin\flang.dll : fatal error LNK1120: 8 unresolved externals

albertziegenhagel · 2017-10-25T09:28:42Z

FYI: @diorcety has a branch [1] that ported flang to windows in his own fork as well. I don't know how far he got but I think he did very similar changes to yours. Maybe your work can benefit from one another:

[1] https://github.com/diorcety/flang/tree/win32

ghost · 2017-10-25T15:28:31Z

He doesn't have sbrk either!

isuruf · 2017-10-25T15:28:51Z

That branch has almost all of our fixes and some not in this PR.

ghost · 2017-10-25T15:32:16Z

@albertziegenhagel It would be helpful if you wrote functions for some of those symbols.

ghost · 2017-10-25T15:38:11Z

Looks like no one responded to his first PR and he gave up. That is sad.

albertziegenhagel · 2017-10-25T17:40:53Z

I may have time to look into some of the functions this weekend.

It would be interesting to see how mature the windows files that @sscalpone mentioned are. I don't think it makes sense to do all of the work twice in the end.

ghost · 2017-10-25T18:28:29Z

Switching the branch...

ghost · 2017-10-25T18:29:55Z

Continues in #288.

xoviat added 6 commits October 20, 2017 10:57

MAINT: include win32 headers

7c60702

ENH: allow getcpu to work on windows

40a509a

FIX: type

c536602

FIX: types

e11c001

FIX: types

3db63d7

FIX: typo

f869d3c

isuruf and others added 21 commits October 21, 2017 06:26

Windows Fixes

1fb9d7d

Remove ifndefs

f88bde0

Merge pull request #1 from isuruf/windows

9a85087

Windows Fixes

Rename WIN32->_WIN32

f7ae936

Add empty methods for __abort_* methods temporarily

1f9c24e

More windows fixes

7037215

Don't use grep or sort

e7f9ea6

Fix generating upperilm.sort

0f428b1

Add truncate definition; thanks to @xoviat

452047c

Add empty methods for mkstemp and vasprintf

f0cbfc3

ENH: implement new win32 functions

d96738b

FIX: types

a3fc1dd

Fix _WIN32

8a117ac

Merge branch 'windows' of https://github.com/isuruf/flang

238b722

Use asprintf from https://github.com/littlstar/asprintf.c

f3759be

Fix more _WIN32

b828ea8

Implement dtime3f for windows. credits to xoviat

284a664

Remove annoying asserts

88b6886

More WIN32

76911b9

sed WINNT, WIN32, WIN64 -> _WIN32 for runtime/flang

d5440d6

Merge pull request #2 from isuruf/windows

0e270f6

WIP Windows

Merge pull request #4 from isuruf/windows

890322e

More windows fixes

ghost commented Oct 24, 2017

View reviewed changes

xoviat added 5 commits October 24, 2017 20:30

[runtime/amod] remove _win32 ifdefs

d31a96c

[runtime/mthdecls] win64 -> win32

9f2bfc7

[runtime/utils] add fortio binary mode

14b631e

[runtime/utils] add gettimeofday

5845da3

[runtime/utils] externalize gettimeofday

b5aa05f

ghost closed this Oct 25, 2017

ghost deleted the windows branch October 25, 2017 18:29

This pull request was closed.

Conversation

ghost commented Oct 20, 2017

Uh oh!

ghost commented Oct 20, 2017

Uh oh!

sscalpone commented Oct 20, 2017

Uh oh!

ghost commented Oct 22, 2017

Uh oh!

ghost commented Oct 24, 2017

Uh oh!

sscalpone commented Oct 24, 2017

Uh oh!

ghost commented Oct 24, 2017

Uh oh!

ghost commented Oct 24, 2017

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost Oct 24, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

isuruf commented Oct 24, 2017

Uh oh!

ghost commented Oct 24, 2017

Uh oh!

ghost commented Oct 24, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isuruf commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

isuruf commented Oct 25, 2017

Uh oh!

albertziegenhagel commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

isuruf commented Oct 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

albertziegenhagel commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

ghost commented Oct 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ghost Oct 24, 2017 •

edited by ghost

Loading

ghost commented Oct 24, 2017 •

edited by ghost

Loading

isuruf commented Oct 25, 2017 •

edited

Loading