Pure/elemental violation detection#29
Open
bolgrebolgre wants to merge 2 commits into
Open
Conversation
Author
|
Made a change in semfin.c to allow value attribute in pure procedures without using intent(in). |
Collaborator
|
@bolgrebolgre Can you consider rebasing this PR and making it ready for a review? |
Author
|
@kiranchandramohan I will look into this. Would you mind if I start early next week? I am away from computer this week so probably difficult to work on this. Thanks! |
Collaborator
|
Thanks @bolgrebolgre for the reply. Yes, next week would be fine. We have a queue of PRs to review and work on. Was just going through the older PRs (like this one) to ensure they are also being considered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in flang1:
(1) The severity was changed from 2 to 3 for pure attribute violation. (semant3.c, rest.c and semfin.c).
(2) A new error was added for the case when dummy arguments are not defined as intent(in) (semfin.c)
(3) A new error code 600 was added in errmsg-in.n for (2). The name of the dummy argument and the procedure who has violated the pure attribute are marked with color (brown-red).
Changes in runtime/flang/ieee_exception.F95 and ieee_arithmetic.F95 to remove pure/elemental violation errors during building process.