Skip to content

Task_2_1_1#11

Open
flash11 wants to merge 12 commits intomainfrom
Task_2_1_1
Open

Task_2_1_1#11
flash11 wants to merge 12 commits intomainfrom
Task_2_1_1

Conversation

@flash11
Copy link
Copy Markdown
Owner

@flash11 flash11 commented Sep 15, 2025

No description provided.

flash11 and others added 9 commits January 28, 2024 17:54
Signed-off-by: Vladislav Dalevich <v.dalevich@g.nsu.ru>
Signed-off-by: Vladislav Dalevich <v.dalevich@g.nsu.ru>
Signed-off-by: Vladislav Dalevich <v.dalevich@g.nsu.ru>
Signed-off-by: Vladislav Dalevich <v.dalevich@g.nsu.ru>
Signed-off-by: Vladislav Dalevich <v.dalevich@g.nsu.ru>
@github-actions
Copy link
Copy Markdown

File Coverage [88.65%] 🍏
SequentialDetector.java 100% 🍏
ParallelDetector.java 100% 🍏
TaskDelimiter.java 96.3% 🍏
PrimeNumbersDetectorUtils.java 88% 🍏
ThreadedDetector.java 81.16% 🍏
Total Project Coverage 88.65% 🍏

@github-actions
Copy link
Copy Markdown

File Coverage [88.65%] 🍏
SequentialDetector.java 100% 🍏
ParallelDetector.java 100% 🍏
TaskDelimiter.java 96.3% 🍏
PrimeNumbersDetectorUtils.java 88% 🍏
ThreadedDetector.java 81.16% 🍏
Total Project Coverage 88.65% 🍏

@github-actions
Copy link
Copy Markdown

File Coverage [88.81%] 🍏
SequentialDetector.java 100% 🍏
ParallelDetector.java 100% 🍏
TaskDelimiter.java 96.3% 🍏
PrimeNumbersDetectorUtils.java 88% 🍏
ThreadedDetector.java 81.16% 🍏
Total Project Coverage 88.81% 🍏

@github-actions
Copy link
Copy Markdown

File Coverage [88.81%] 🍏
SequentialDetector.java 100% 🍏
ParallelDetector.java 100% 🍏
TaskDelimiter.java 96.3% 🍏
PrimeNumbersDetectorUtils.java 88% 🍏
ThreadedDetector.java 81.16% 🍏
Total Project Coverage 88.81% 🍏

@flash11 flash11 requested a review from BIGNIKi September 15, 2025 13:06
/**
* Класс, реализующий параллельное решение.
*/
public class ParallelDetector implements PrimeNumbersDetector {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как бы ты, как архитектор, принял решение: нужно реализовать интерфейс, нужно унаследовать класс или вообще ничего не нужно?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Разобраться, что такое абстрактный класс и тогда уже рассказать

* @return true if numbers are not all prime.
*/
@Override
public boolean isNotPrimeNumbers(Integer[] numbers) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Рассказать про ссылочные типы/значимые

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Разница передачи как аргумента?

Copy link
Copy Markdown
Collaborator

@BIGNIKi BIGNIKi Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем ввели ссылочные типы для всех значимых?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Какой класс нужен, чтобы строку в цикле делать?

}
});

newThread.setUncaughtExceptionHandler(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Рассказать зачем вызвал это


newThread.setUncaughtExceptionHandler(
(thread, exception) -> {
synchronized (System.err) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Рассказать, как работает synchronized, зачем ему передавать аргумент?
Рассказать чем отличается synchronized обычный в методе, synchronized метод и synchronized у static метода.

/**
* Класс, реализующий многопоточное решение.
*/
public class ThreadedDetector implements PrimeNumbersDetector {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличие процесса от потока?

int len = TaskDelimiter.lenThreadPart(threadIdx, threadQuantity, numbers.length);
threads[threadIdx] = createThread(offset, len, numbers, result);

threads[threadIdx].start();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runable.run vs Thread.Start - разница в чем?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants