This repository was archived by the owner on May 12, 2025. It is now read-only.
Use Logs instead of entire SimulateTransactionResults#27
Open
Conversation
jinmel
requested review from
Ruteri,
dmarzzz,
ferranbt,
lthibault and
metachris
as code owners
Is this with the JSON library or with plain abi.encode functions? |
Author
|
@ferranbt https://github.com/flashbots/suave-geth/blob/main/suave/sol/standard_peekers/bundles.sol This fails to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suave.sol does not compile with "stack too deep" due to nested structs for
SimulateBundleResult. This PR does a diet to reduce number of local variables