This repository was archived by the owner on Apr 25, 2022. It is now read-only.
Add endpoint for generating JWTs#148
Open
jameswestman wants to merge 2 commits into
Open
Conversation
danielsilverstone-ct
previously requested changes
Mar 11, 2022
Contributor
danielsilverstone-ct
left a comment
danielsilverstone-ct
left a comment
There was a problem hiding this comment.
I think this is OK, I take it the secret here is just a test secret you were using locally?
With the request I made resolved, I think this could be merged. But the TODO will be critical for that to be OK.
jameswestman
force-pushed
the
jwt
branch
2 times, most recently
from
e7422cf to
e018a70
Compare
Contributor
Author
|
Added a TODO. |
These tokens are provided to flat-manager to authorize the user to download an app. In the future, this enpoint should first check whether the user has paid for the app if necessary.
jameswestman
dismissed
danielsilverstone-ct’s stale review
The access check is now in place.
Add a table, UserOwnedApp, to track which users have bought/otherwise have access to which apps. Currently there is no way to add entries to this table; that is part of the payment processing work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tokens are provided to flat-manager to authorize the user to download an app. In the future, this enpoint should first check whether the user has paid for the app if necessary.