Decouple the app version from the pinned ezvpn core - #28
Merged
Merged
Conversation
MARKETING_VERSION goes back to 0.0.2 (3): the app's own version, which the v0.0.44 bump had wrongly overwritten with the core release number. The core release now lives in its own project.yml setting, EZVPN_CORE_VERSION, surfaced through Info.plist (EzvpnCoreVersion) so the footer reads "v0.0.2 (3) · core 0.0.44". bump-xcframework.sh switches to core-key mode and only rewrites that setting, matching flextunnel-ios. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MARKETING_VERSIONback to 0.0.2 (build 3): the app's own version, independent of the core release. The v0.0.44 bump had overwritten it.EZVPN_CORE_VERSIONsetting inproject.yml, exposed viaInfo.plistasEzvpnCoreVersion; the footer now readsv0.0.2 (3) · core 0.0.44.scripts/bump-xcframework.shruns incore-keymode (same as flextunnel-ios) and only rewrites the core setting.Test plan
scripts/bump-xcframework.sh v0.0.44is a no-op diff (verified locally)🤖 Generated with Claude Code
https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y