Decouple the app version from the pinned ezvpn.dll - #23
Merged
Merged
Conversation
Directory.Build.props EzvpnVersion becomes EzvpnAppVersion, the app's own version: bump-dll.ps1 no longer rewrites it when re-pinning the DLL. The pinned release is surfaced separately as EzvpnCoreVersion (derived from EzvpnReleaseTag in native.targets) and stamped into the Ezvpn.App assembly metadata so the main window header reads "v0.0.44 · core v0.0.44". Add/Remove Programs keeps showing the app version. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EzvpnVersioninDirectory.Build.propsis renamedEzvpnAppVersionand is now the app's own version;scripts/bump-dll.ps1no longer touches it when re-pinning the DLL.native/native.targetsderivesEzvpnCoreVersionfromEzvpnReleaseTag;Ezvpn.App.csprojstamps it as assembly metadata andAppInfoexposes it. The main window header now readsv0.0.44 · core v0.0.44; the tray menu and Add/Remove Programs keep the app version.Test plan
pwsh scripts/bump-dll.ps1 v0.0.44is a no-op diff (verified locally)🤖 Generated with Claude Code
https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y