Skip to content

fix: 🐛 hide podcast platform buttons when the episode has no URL #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flexbox merged 1 commit into from
Sep 23, 2026
Merged

fix: 🐛 hide podcast platform buttons when the episode has no URL #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 29 additions & 23 deletions apps/web/components/podcast-episode-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,30 +40,36 @@ export function PodcastEpisodeCard({ episode }: PodcastEpisodeCardProps) {
</div>
</Link>

<div className="p-4 pt-0">
<div className="flex gap-3">
<Button
as="a"
href={episode.spotify_url}
isExternalLink={true}
size="md"
variant="outline"
accessoryLeft={<SpotifyIcon />}
>
Spotify
</Button>
<Button
as="a"
href={episode.apple_podcast_url}
isExternalLink={true}
size="md"
variant="outline"
accessoryLeft={<ApplePodcastIcon />}
>
Apple Podcast
</Button>
{(episode.spotify_url || episode.apple_podcast_url) && (
<div className="p-4 pt-0">
<div className="flex gap-3">
{episode.spotify_url && (
<Button
as="a"
href={episode.spotify_url}
isExternalLink={true}
size="md"
variant="outline"
accessoryLeft={<SpotifyIcon />}
>
Spotify
</Button>
)}
{episode.apple_podcast_url && (
<Button
as="a"
href={episode.apple_podcast_url}
isExternalLink={true}
size="md"
variant="outline"
accessoryLeft={<ApplePodcastIcon />}
>
Apple Podcast
</Button>
)}
</div>
</div>
</div>
)}
</Card>
);
}
14 changes: 10 additions & 4 deletions apps/web/components/transcript-entry.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,22 @@ export function TranscriptEntry({
spotify_url?: string;
}) {
const seconds = timecodeToSeconds(entry.time);
const spotifyUrl = `${spotify_url}${spotify_url?.includes('?') ? '&' : '?'}t=${seconds}`;
const spotifyUrl = spotify_url
? `${spotify_url}${spotify_url.includes('?') ? '&' : '?'}t=${seconds}`
: undefined;

return (
<div className="mb-4">
<div className="flex items-baseline gap-2 mb-1">
<span className="font-semibold">{entry.speaker}</span>
<span className="text-slate-500">-</span>
<Hyperlink href={spotifyUrl} isExternal>
{entry.time}
</Hyperlink>
{spotifyUrl ? (
<Hyperlink href={spotifyUrl} isExternal>
{entry.time}
</Hyperlink>
) : (
<span className="text-slate-500">{entry.time}</span>
)}
</div>
<p className="whitespace-pre-line pl-2 border-l-2 border-blue-200 dark:border-blue-800 mt-0">
{entry.text}
Expand Down
60 changes: 33 additions & 27 deletions apps/web/pages/podcast/[slug].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,34 +196,40 @@ export default function PodcastEpisodePage({
/>
)}
</div>
<Card>
<Text as="h2" variant="h3" className="mb-6">
Écouter l'épisode
</Text>
<div className="flex flex-wrap gap-4">
<Button
as="a"
href={episode.spotify_url}
isExternalLink={true}
size="lg"
variant="spotify"
accessoryLeft={<SpotifyIcon />}
>
Écouter sur Spotify
</Button>
{(episode.spotify_url || episode.apple_podcast_url) && (
<Card>
<Text as="h2" variant="h3" className="mb-6">
Écouter l'épisode
</Text>
<div className="flex flex-wrap gap-4">
{episode.spotify_url && (
<Button
as="a"
href={episode.spotify_url}
isExternalLink={true}
size="lg"
variant="spotify"
accessoryLeft={<SpotifyIcon />}
>
Écouter sur Spotify
</Button>
)}

<Button
as="a"
href={episode.apple_podcast_url}
isExternalLink={true}
size="lg"
variant="apple"
accessoryLeft={<ApplePodcastIcon />}
>
Écouter sur Apple Podcast
</Button>
</div>
</Card>
{episode.apple_podcast_url && (
<Button
as="a"
href={episode.apple_podcast_url}
isExternalLink={true}
size="lg"
variant="apple"
accessoryLeft={<ApplePodcastIcon />}
>
Écouter sur Apple Podcast
</Button>
)}
</div>
</Card>
)}
{episode.youtube_embed_id && (
<Card className="my-6">
<Text as="h2" variant="h4" className="mb-4">
Expand Down
Loading