Relay migrated simulation schema services from flow360-schema#1998
Closed
benflexcompute wants to merge 31 commits intomainfrom
Closed
Relay migrated simulation schema services from flow360-schema#1998benflexcompute wants to merge 31 commits intomainfrom
benflexcompute wants to merge 31 commits intomainfrom
Conversation
…tem to flow360-schema Migrate Flow360BaseModel, length types, and operation condition models to the external flow360-schema package. Remove now-redundant mixin classes and update dependencies. Add CodeArtifact CI setup and coverage reporting.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Stan-Flexcompute <168167683+Stan-He-5@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…1943) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix LengthType import error: replace deprecated LengthType.validate() with Length.PositiveFloat64 + DeserializationContext in geometry.py Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ys (#1945) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
flow360/component/simulation/into thin relays over schema-owned implementationsservices_utilsWhy
The migration target is for the client to keep runtime-only responsibilities such as translator orchestration, web API code, BET wrappers, and unit-switching, while schema owns Pydantic behavior, validation, and deserialization.
Impact
Validation
python -m py_compile flow360/component/simulation/services.py flow360/component/simulation/services_utils.py flow360/component/simulation/conversion.py flow360/component/simulation/utils.py flow360/component/simulation/framework/updater.py flow360/component/simulation/framework/updater_functions.py flow360/component/simulation/framework/updater_utils.pyflow360-schemapackage during developmentPaired Schema PR
Remaining Work From Plan
unit_system.py/exposed_units.pyonly after confirming real remaining consumerstests/simulation/params/test_validators_params.pyandtests/simulation/services/test_selector_expansion_validators.pyFollow-up
This PR is intentionally scoped as the first reviewable client-side relay cleanup batch. The remaining items should be finished in a follow-up PR rather than expanding this one further.