Merged
Conversation
piotrkluba
requested review from
daquinteroflex,
maciej-flexcompute and
wiktor-flex
|
Spell check passed successfully for 1 notebook(s). |
daquinteroflex
approved these changes
Apr 22, 2025
Collaborator
There was a problem hiding this comment.
Looks about right from what I can tell, good job! The rest of the things like (sync and docs index) missing can be added later but looks like it's the shared structure for now. As long as you checked the spellchecker and linting action work then seems fine by me? Also actions can also be debugged during the first PR if need be, but looks the same as ours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created basic git files, added nbdiff as a custom tool for diffing and merging Jupyter notebooks, defined a github action for spellchecking using codespell