Open
Conversation
awkrupka
reviewed
Oct 20, 2023
| float ei = quadricError(qi, vertex_positions[i1]); | ||
| float ej = quadricError(qj, vertex_positions[j1]); | ||
|
|
||
| if(fabsf(vertex_mach[i1] - vertex_mach[j1]) >= mach_bound256) { |
There was a problem hiding this comment.
This is the main difference - when mach value difference at opposite edge points pass a given threshold we set error to a high value which prevents collapse, looks good.
There was a problem hiding this comment.
Idea - if we wanted to collapse the mesh further we could try checking whether the parameter-wise second derivatives of the velocity field (rate of gradient change) are non-zero in preprocessing - for values close to zero we could collapse the edges anyway and handle color changes from the shader via simple builtin UV bilinear interpolation.
awkrupka
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.