refactor(notebooks): use internal adam and optimize helper - batch 4#465
Draft
marcorudolphflex wants to merge 1 commit intodevelopfrom
Draft
refactor(notebooks): use internal adam and optimize helper - batch 4#465marcorudolphflex wants to merge 1 commit intodevelopfrom
marcorudolphflex wants to merge 1 commit intodevelopfrom
Conversation
Contributor
|
Spell check passed successfully for 5 notebook(s). |
5692255 to
a76d195
Compare
Contributor
Author
|
will rerun Autograd27 with other seed to check if we can still see that objective setback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up from #463
Replaces the optax adam with our adam and make usage of the optimize helper when easy possible. This is the fourth batch of it with 5 out of ~20 notebooks to make that reviewable.
results are roughly unchanged, here some notable differences: (will insert images here later)
Autograd25WaveguideCrossing.ipynb: had to change fwidth from f0/20 to f0/5, got glitchy transmissions > 1 otherwise.


Objective (max.): develop 9.6852e-01 vs. branch 9.4947e-01
develop:
branch:
Autograd26DiffractiveBeamSplitter.ipynb
develop:
branch:
Autograd27Smatrix.ipynb⚠️

Objective (min.): develop 1.0909e-02 vs branch 3.6146e-02
develop
branch

Autograd28FiberLens.ipynb
objective (max.): develop 4.0160e-02 vs. branch 4.0133e-02
(plot/result nearly unchanged)
Autograd7Metalens.ipynb
objective (max.): develop 2.2378e+01 vs. branch 2.3344e+01
(plot/result nearly unchanged)