Skip to content

chore: rerun ThermoOpticDopedModulator with eps broadcast fix#466

Open
daquinteroflex wants to merge 2 commits intodevelopfrom
dario/fix-eps-broadcast-notebook-rerun
Open

chore: rerun ThermoOpticDopedModulator with eps broadcast fix#466
daquinteroflex wants to merge 2 commits intodevelopfrom
dario/fix-eps-broadcast-notebook-rerun

Conversation

@daquinteroflex
Copy link
Copy Markdown
Collaborator

Summary

  • Rerun ThermoOpticDopedModulator.ipynb after fixing shape mismatch in Simulation.epsilon_on_grid()
  • All 39 code cells execute successfully
  • Depends on flexcompute/compute#4537 (squeeze frequency dimension + reshape guard in make_eps_data)

Test plan

  • All 39 code cells execute without error
  • Verify output images/plots match expected results

🤖 Generated with Claude Code

Rerun after fixing shape mismatch in Simulation.epsilon_on_grid
(flexcompute/compute#4537). All 39 code cells pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Spell Check Report

ThermoOpticDopedModulator.ipynb:

Cell 12, Line 1: 'Heat-Charge'
  > ## Heat-Charge simulation
Cell 17, Line 3: 'Heat-Charge'
  > We create now all the structures used in both the optic and Heat-Charge simulations.
Cell 25, Line 2: 'Heat-Charge'
  > Since we're interested in the response of the system for different applied voltages we'll need to solve the Heat-Charge problem at each of these voltages.
Cell 33, Line 1: 'Heat-Charge'
  > ### Heat-Charge simulation object
Cell 53, Line 8: 'NedeljkovicSorefMashanovich'
  > For the Si charge-induced variation, we will use the empirical relationships presented in `M. Nedeljkovic, R. Soref and G. Z. Mashanovich, "Free-Carrier Electrorefraction and Electroabsorption Modulation Predictions for Silicon Over the 1–14- μm Infrared Wavelength Range," IEEE Photonics Journal, vol. 3, no. 6, pp. 1171-1180, Dec. 2011 ` which has been implemented in the class `NedeljkovicSorefMashanovich`.

Checked 1 notebook(s). Found spelling errors in 1 file(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/24007456697

Rerun with commit 30e3392d96 which explicitly squeezes the trailing
singleton f axis instead of reshaping. All 39 cells pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant