Open
Conversation
Collaborator
Author
Notebook Fixes SummaryThis PR fixes 4 notebooks that were failing in CI (run #23868661354) due to API changes, type validation, and deprecated NumPy functions. All notebooks were re-executed locally to regenerate outputs. Fixes by notebook1.
|
These two notebooks need library-side fixes (unstructured grid API change and dict mutation in batch runner respectively), not notebook code changes. Reverting to develop to keep this PR scoped to notebook-level fixes only. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Spell Check ReportDirectionalCouplerSurrogate.ipynb: Checked 5 notebook(s). Found spelling errors in 1 file(s). |
Collaborator
|
Not urgent but I guess best to clear this
I am confused about the HeatSolver. It was fixed in this PR. I am not sure why your changes here seem to apply to an older version of the notebook. |
Collaborator
|
Oh regarding the HeatSolver it's supposed to be a revert? But I'm confused about the diff it shows here. Maybe some issue in notebook diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rerun the affected notebooks and regenerate the optimized reflector GDS output.
Files updated:
Reverted (need library-side fixes, not notebook changes):
TemperatureMonitornow defaultsunstructured=True, returningTetrahedralGridDatasetinstead ofSpatialDataArray. Notebook needs updating after the library API stabilizes.dictionary changed size during iterationinbatch.run()is a tidy3d library bug.Validation: rerun locally and committed the resulting notebook outputs / generated asset changes.