Update CPWRFPhotonics1 notebook after WavePort improvements#473
Open
yuanshen-flexcompute wants to merge 1 commit intodevelopfrom
Open
Update CPWRFPhotonics1 notebook after WavePort improvements#473yuanshen-flexcompute wants to merge 1 commit intodevelopfrom
yuanshen-flexcompute wants to merge 1 commit intodevelopfrom
Conversation
Notebook update
Contributor
|
Spell check passed successfully for 1 notebook(s). |
mingzhou-flex
left a comment
mingzhou-flex
left a comment
There was a problem hiding this comment.
Cell 44:
- lists "n_eff, α, and α" — the third symbol should be β if I understand it correctly.
- Also, the formula "γ = β + jα" is not consistent with the code; code uses γ = α+ jβ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made changes to the wave port definition and model setup, in view of improvements to the wave port and simplification to the user experience.