Skip to content

Create Actions for automatic binding generation#37

Open
leandro-benedet-garcia wants to merge 1 commit into
flibitijibibo:mainfrom
leandro-benedet-garcia:main
Open

Create Actions for automatic binding generation#37
leandro-benedet-garcia wants to merge 1 commit into
flibitijibibo:mainfrom
leandro-benedet-garcia:main

Conversation

@leandro-benedet-garcia

Copy link
Copy Markdown
Contributor

Hello, here we go, a pretty convoluted actions

Do we really need to build SDL3 and c2ffi?
Check the comments, I iterated trough a lot of things to check what was needed and what wasn't, what I could cache and what I couldn't.

@flibitijibibo flibitijibibo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good as does the build test. There's probably a way to optimize but we ran into the same issues too: I wouldn't be surprised if c2ffi's dependency on llvm versions prevented it from being packaged. As for SDL... I thought I had it working with something like -I but maybe our generator has to be naiive and assume SDL is cloned next to SDL3#. @thatcosmonaut may know what's up, otherwise I'll try and compress CI further this weekend.

@leandro-benedet-garcia

Copy link
Copy Markdown
Contributor Author

The changes look good as does the build test. There's probably a way to optimize but we ran into the same issues too

I tried to cache as much as possible and also run a couple times the actions with and without the cache, that's how I caught that I had to install the apt packages always so SDL doesn't rebuild all the time.

I wouldn't be surprised if c2ffi's dependency on llvm versions prevented it from being packaged.

Unsure, because you can install multiple versions of llvm, at least in arch.
And even then there is flatpak, or zip file with static linking (at least I think you can do that)

I might create a github action for c2ffi in the future, but shall see.

As for SDL... I thought I had it working with something like -I but maybe our generator has to be naiive and assume SDL is cloned next to SDL3#. @thatcosmonaut may know what's up, otherwise I'll try and compress CI further this weekend.

The -I argument works. Locally, and only locally. Not in CI for some reason. Maybe I messed up the paths when I tested, but considering I remember copy and pasting the same path used in GenerateBindings, I believe I didn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants