Skip to content

EDM-4520: Scroll enrolled Devices table before row interactions #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dudyas6 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EDM-4520: Scroll enrolled Devices table before row interactions #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions cypress/views/devicesPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ const addVmApplication = (index, app = {}) => {
const enrolledDeviceRows = () =>
cy.get('[data-testid="enrolled-devices-table"] tbody tr[data-testid^="enrolled-device-row-"]')

/** Enrolled table can sit below "Devices pending approval"; scroll it into view before row/link queries. */
const scrollEnrolledDevicesTableIntoView = () => {
cy.get('[data-testid="enrolled-devices-table"]', { timeout: 60000 }).should('exist')
cy.get('[data-testid="enrolled-devices-table"]').scrollIntoView({ block: 'start' })
}

/**
* Closest ancestor of the enrolled table that also contains this list’s pagination (sibling of the
* table in the DOM). Safer than `#devices-toolbar`.parent() when the console wraps the toolbar.
Expand Down Expand Up @@ -261,14 +267,16 @@ const clickEnrolledDeviceNameLinkAcrossPages = (deviceRef, pagesLeft = 8) => {
})
}

/** Enrolled-table row by alias. Callers should chain .scrollIntoView() before interacting. */
/** Enrolled-table row by alias. Pure query — keeps Cypress retry chain for long waits/polling. */
const enrolledDeviceRowByAlias = (deviceName, timeout = 60000) =>
cy.contains('[data-testid="enrolled-devices-table"] tr', deviceName, { timeout })

const enrolledDeviceLinkByAlias = (deviceName, timeout = 60000) =>
enrolledDeviceRowByAlias(deviceName, timeout)
const enrolledDeviceLinkByAlias = (deviceName, timeout = 60000) => {
scrollEnrolledDevicesTableIntoView()
return enrolledDeviceRowByAlias(deviceName, timeout)
.scrollIntoView({ block: 'center' })
.find(`[data-testid^="device-name-link-"]`)
}

/**
* DevicesPage object for device management operations.
Expand Down Expand Up @@ -314,6 +322,7 @@ export const devicesPage = {
cy.get('[data-testid="rich-validation-field-deviceAlias"]').should('have.value', deviceName)
cy.get('[data-testid="approve-device-form-submit"]').should('be.visible')
cy.get('[data-testid="approve-device-form-submit"]').click()
scrollEnrolledDevicesTableIntoView()
enrolledDeviceRowByAlias(deviceName, 500000).should('contain', 'Online')
},

Expand Down Expand Up @@ -351,6 +360,7 @@ export const devicesPage = {

editDevice: (image, currentName = 'test-device', newName = 'test-device-edited') => {
common.navigateTo('Devices')
scrollEnrolledDevicesTableIntoView()

enrolledDeviceRowByAlias(currentName)
.scrollIntoView({ block: 'center' })
Expand All @@ -376,7 +386,7 @@ export const devicesPage = {

checkDeviceOutOfDate: (deviceName = 'test-device-edited2') => {
common.navigateTo('Devices')
enrolledDeviceLinkByAlias(deviceName)
scrollEnrolledDevicesTableIntoView()

const intervalMs = 5000
const totalMs = 120000
Expand Down Expand Up @@ -408,6 +418,7 @@ export const devicesPage = {

decommissionDevice: (deviceName = 'test-device-edited2') => {
common.navigateTo('Devices')
scrollEnrolledDevicesTableIntoView()

enrolledDeviceRowByAlias(deviceName)
.scrollIntoView({ block: 'center' })
Expand Down Expand Up @@ -501,6 +512,7 @@ export const devicesPage = {
}
})
cy.get('[data-testid="enrolled-devices-table"]', { timeout: 60000 }).should('exist')
scrollEnrolledDevicesTableIntoView()
},

/**
Expand Down Expand Up @@ -690,6 +702,7 @@ export const devicesPage = {

openEditDeviceConfigurations: (deviceName) => {
common.navigateTo('Devices')
scrollEnrolledDevicesTableIntoView()
enrolledDeviceRowByAlias(deviceName)
.scrollIntoView({ block: 'center' })
.find(`[data-testid^="device-row-actions-"] .pf-v6-c-menu-toggle`)
Expand Down