[sc-50634] Erumu: Refactor Various Input Modules to Use New Input.Builder Module - #29
Closed
robmagary wants to merge 1 commit into
Closed
[sc-50634] Erumu: Refactor Various Input Modules to Use New Input.Builder Module#29robmagary wants to merge 1 commit into
robmagary wants to merge 1 commit into
Conversation
…, amnd CheckboxInput to use the builder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by the current need to add input types for email and password while limiting the text that can be passed to the
type_ <input-type>attribute and avoiding repetitive copying of existing module functions like render, fill, etc.renderWithTypehelper in favor of thewithEmailValueandwithPasswordValue. Those could have been namedwithPasswordTypeandwithEmailType,but I chose to follow the syntax of thewithValuehelper. It could also be confusing becausewithPasswordTypeimplied the type is Password instead of String.