Skip to content

[sc-50634] Erumu: Refactor Various Input Modules to Use New Input.Builder Module - #29

Closed
robmagary wants to merge 1 commit into
mainfrom
rob/sc-50634/erumu-input-builder
Closed

[sc-50634] Erumu: Refactor Various Input Modules to Use New Input.Builder Module#29
robmagary wants to merge 1 commit into
mainfrom
rob/sc-50634/erumu-input-builder

Conversation

@robmagary

Copy link
Copy Markdown
Contributor

This is motivated by the current need to add input types for email and password while limiting the text that can be passed to the type_ <input-type> attribute and avoiding repetitive copying of existing module functions like render, fill, etc.

  • Adds Input.Builder module and revises TextInput, FileInput, and CheckboxInput to use the builder
  • Does not add additional input types but sets the pattern to do so.
  • Preserves the previous API for the three input types, minus the recently added renderWithType helper in favor of the withEmailValue and withPasswordValue. Those could have been named withPasswordType and withEmailType, but I chose to follow the syntax of the withValue helper. It could also be confusing because withPasswordType implied the type is Password instead of String.

@robmagary
robmagary requested a review from qxjit June 18, 2026 14:03
@robmagary robmagary closed this Jun 18, 2026
@robmagary
robmagary deleted the rob/sc-50634/erumu-input-builder branch June 18, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant