[sc-50634] Reverts TextInput Helpers and InputType - #31
Merged
robmagary merged 1 commit intoJun 22, 2026
Merged
Conversation
…assing custom properties in the user props on the renderWith fuction
ysangkok
approved these changes
Jun 22, 2026
robmagary
deleted the
rob/sc-50634/erumu-revert-input-type-email-and-password
branch
June 22, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts TextInput helpers and InputType in favor of just passing custom properties in the user props agrs on the renderWith function. This keeps the TextInput very flexible. We currently use this method in Merlin for the password field, and the passed
type="password"property overwrites the TextInput'stype="text"property.The helper APIs that this PR resets are, ultimately, just more plumbing when threaded through Breathmint for something we can already do.