Skip to content

feat(core): add console warn when editor container has no explicit he… - #349

Open
ccc1110 wants to merge 1 commit into
floatboatai:mainfrom
ccc1110:feat-core/add-container-height-warn
Open

ccc1110 wants to merge 1 commit into
floatboatai:mainfrom
ccc1110:feat-core/add-container-height-warn

Conversation

@ccc1110

@ccc1110 ccc1110 commented Sep 18, 2026

Copy link
Copy Markdown

Summary / 摘要

Add console warning to remind developers when editor container does not have explicit height, help quickly locate blank editor rendering issue.

Motivation / 背景与动机

When users forget to set height for the editor container, the editor area will show blank without obvious error message.
This warning can output tips in browser console to reduce debugging cost.

Changes / 变更内容

  • packages/core: Add container height detection logic after editor mount, print warning when computed height is 0.

  • packages/core: Add corresponding unit test in editor.test.ts.

  • Issue:

Note: Local Windows electron-demo test failures are caused by symlink permission limitation on Windows OS, unrelated to this core editor warning feature. CI(Linux) will run without this problem.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants