feat(toolbar): add selection-triggered inline floating toolbar (closes #327) - #366
Open
fengguoheng wants to merge 1 commit into
Open
fengguoheng wants to merge 1 commit into
fengguoheng wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #327.
Summary
Adds an opt-in inline floating toolbar to plugin-toolbar that appears when the user selects text inside the editor - the same affordance Notion / Google Docs / Medium offer for inline formatting.
Mirrors the proven lifecycle of createSlashMenuUI (selection-triggered, viewport-flipping, IME-aware, dismiss-on-outside-click) and reuses the existing ToolbarButton / ToolbarGroup types and toolbar-commands actions so hosts can compose their own button sets with zero new dependencies.
What is included
Why this design
Test plan