Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Fix the remaining Windows-only test failure (
O_NONBLOCKassertion) and add regression coverage assertingLinkIndexbehaves identically for\-separated paths — the normalization contract #77 relied on.Motivation / 背景与动机
Related to #77 (same class of Windows-only test assumptions). #77's path-separator half was fixed in bb83c3a, but the full suite on Windows 11 still shows one real failure:
constants.O_NONBLOCKisundefinedon Windows, soopenedFlags & constants.O_NONBLOCKevaluates to+0and the unconditional assertion fails. Test-only change — OpenSpec not required (CONTRIBUTING §3.1).Changes / 变更内容
test/plugin-host-broker.test.ts: guard theO_NONBLOCKassertion with the same!== undefinedcheck the test already uses forO_NOFOLLOWtwo lines below. Production code already passes(constants.O_NONBLOCK ?? 0)— no production change needed.test/link-index.test.ts: newpath separator normalizationdescribe —\-separated indexing produces results identical to/input (names/files/resolve/backlinks/unlinked mentions), and incremental ops (updateFile/renameFile/removeFile) plus mixed-separator lookups normalize correctly. Deterministic on any OS.Testing / 测试
pnpm test— 900/900 on Windows 11, Node 22.20.0, pnpm 9.15.4 (was 1 failed / 898 total before)pnpm typecheck+pnpm build— pass on Windowspath separator normalizationtests + guardedO_NONBLOCKassertionCompliance / 合规自检
Checklist / 自检清单
live-preview-table.ts, no capability/breaking changeapps/electron-demo)