fix(sender): encode the files sent from matcha (#83) #84
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the encoding of files sent from matcha by adding proper MIME line wrapping for base64-encoded data. According to RFC 2045, base64-encoded data in MIME messages must be wrapped at 76 characters per line with CRLF line endings.
Key Changes:
- Added a new
wrapBase64utility function that wraps base64-encoded strings at 76 characters per line with proper CRLF (\r\n) line endings - Applied line wrapping to embedded images (inline images referenced in emails)
- Applied line wrapping to file attachments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // wrapBase64 wraps base64-encoded data at 76 characters per line as required by MIME. | ||
| func wrapBase64(data string) string { | ||
| const lineLength = 76 | ||
| var result strings.Builder | ||
| for i := 0; i < len(data); i += lineLength { | ||
| end := i + lineLength | ||
| if end > len(data) { | ||
| end = len(data) | ||
| } | ||
| result.WriteString(data[i:end]) | ||
| if end < len(data) { | ||
| result.WriteString("\r\n") | ||
| } | ||
| } | ||
| return result.String() | ||
| } |
There was a problem hiding this comment.
The new wrapBase64 function lacks test coverage. Given that this repository has comprehensive test coverage (as seen in sender_test.go, config_test.go, etc.), a test should be added to verify the function correctly wraps base64 data at 76 characters per line with proper CRLF line endings. Test cases should include: empty string, string shorter than 76 chars, string exactly 76 chars, string longer than 76 chars, and string that requires multiple wraps.
1 participant
No description provided.