feat: honor DOCKER_HOST for Docker daemon resolution#4
Merged
Conversation
Resolve the Docker endpoint from DOCKER_HOST (with the legacy DOCKER_SOCK override and an OS default fallback) so Podman, rootless setups, and remote Docker contexts work without assuming /var/run/docker.sock. start/az start/gcp start bind-mount the resolved unix socket or pass a remote tcp:// daemon through via DOCKER_HOST; doctor's docker.socket check reports the resolved endpoint. Adds DockerHostResolveTest and README documentation. Closes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Docker daemon endpoint from the standard
DOCKER_HOSTenvironment variable so Podman, rootless setups, and remote Docker contexts work without assuming/var/run/docker.sock.Details
DockerClient.parseDockerHost(...)resolver with precedence:DOCKER_HOST(standard) →DOCKER_SOCK(legacy override) → OS default. Classifies the endpoint asUNIX,TCP, orNPIPE.start/az start/gcp startnow usedockerSocketRunArgs(): bind-mount the resolved unix socket, or pass a remotetcp://daemon through to the container viaDOCKER_HOST.floci doctor'sdocker.socketcheck reports the resolved endpoint (unix path, remote daemon, or named pipe).DockerHostResolveTest(10 cases) and README documentation.Testing
mvn test— 33 passing (incl. newDockerHostResolveTest).floci doctoragainst default socket,tcp://remote, and a Podmanunix://socket.Closes #3