Skip to content

Correct fractional-hour offset conversion and display #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Correct fractional-hour offset conversion and display #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49261b3
Correct fractional-hour offset conversion and display
OskarEichler Aug 27, 2026
11cce4c
Add regression test for et-orbi PR #52
OskarEichler Aug 28, 2026
2126101
Store plain-text regression test for et-orbi PR #52
OskarEichler Aug 28, 2026
79707e0
Fix fractional offset assertions
OskarEichler Aug 29, 2026
c72d3de
Match fractional offset test style
OskarEichler Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/et-orbi/time.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def to_debug_s
uo = self.utc_offset
uos = uo < 0 ? '-' : '+'
uo = uo.abs
uoh, uom = [ uo / 3600, uo % 3600 ]
uoh, uom = [ uo / 3600, (uo % 3600) / 60 ]

[
'ot',
Expand Down
4 changes: 2 additions & 2 deletions lib/et-orbi/zone.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def get_offset_tzone(str)

hr = nil if hr.abs > 11
hr = nil if mn > 59
mn = -mn if hr && hr < 0
mn = -mn if m[1].start_with?('-')

hr ?
custom_tzs[str] = create_offset_tzone(hr * 3600 + mn * 60, str) :
Expand Down Expand Up @@ -85,7 +85,7 @@ def to_offset(n)

i = n.to_i
sn = i < 0 ? '-' : '+'; i = i.abs
hr = i / 3600; mn = i % 3600; sc = i % 60
hr = i / 3600; mn = (i % 3600) / 60; sc = i % 60

sc > 0 ?
'%s%02d:%02d:%02d' % [ sn, hr, mn, sc ] :
Expand Down
11 changes: 11 additions & 0 deletions test/module_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,17 @@
end
end

test 'handles fractional-hour offsets' do

assert EtOrbi.get_tzone(19_800).name, '+05:30'
assert EtOrbi.get_tzone(-1_800).name, '-00:30'
assert EtOrbi.get_tzone('-00:30').name, '-00:30'

assert(
EtOrbi::EoTime.new(0, 19_800).to_debug_s,
'ot 1970-01-01 05:30:00 +05:30 dst:false')
end

# test 'returns a timezone for well-known abbreviations' do
#
# assert gtz('JST'), 'Japan'
Expand Down