Resolve macOS timezone names relative to zoneinfo - #56
Open
OskarEichler wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the IANA name after /zoneinfo/ instead of assuming a fixed number of path components in /etc/localtime's symlink target.
On the inspected macOS installation, the target is /var/db/timezone/zoneinfo/Europe/Istanbul. The current code returns "zoneinfo/Europe/Istanbul", which TZInfo rejects; local detection then falls back to an unrelated zone with matching current offsets.
Reproduction
Before:
EtOrbi.osx_tzreturns "zoneinfo/Europe/Istanbul"; automatic detection selected Antarctica/Syowa. After: it returns Europe/Istanbul and detection selects that zone.Checked the actual symlink and temporary readlink substitutions for /usr/share/zoneinfo/Asia/Tokyo and /var/db/timezone/zoneinfo/America/New_York. The traditional path remains supported; a target without a zoneinfo component yields nil for existing fallback handling.
Verification
The current master's unreleased day-delta change was not brought into the consumer branch. No live scheduler or production operations were used. Linux/Windows and other Ruby runtimes were not run locally.
Breaking changes and limitations
No intended breaking API change. Local detection now retains the actual named timezone instead of a fallback with potentially different historical/DST rules. Explicit ENV['TZ'] and Rails Time.zone priority are unchanged. No operating-system files or settings were modified. No overlapping current fix was found.