Retain fractional seconds when adding calendar durations - #126
Open
OskarEichler wants to merge 1 commit into
Open
Retain fractional seconds when adding calendar durations#126OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calendar year/month arithmetic reconstructs a time using integer seconds, silently dropping the input fraction and any fractional seconds already added by the duration. Preserve that remainder after reconstruction to avoid an extra formatted-time precision loss.
Reproduction
Run after
require 'fugit':Verification
Compatibility and limitations
Year/month arithmetic now preserves fractional seconds. This retains EtOrbi's existing floating-point precision; it does not promise arbitrary precision or change end-of-month/DST policy.
No dependency/version upgrades, test additions or test modifications are included. The task's no-new-tests constraint was followed; reproduction/check scripts stayed outside the repository. Other Ruby versions and platforms await upstream CI. No production execution was performed. Prepared with Codex assistance.