Skip to content

Preserve ArgumentError for invalid non-string cron inputs - #130

Open
OskarEichler wants to merge 1 commit into
floraison:masterfrom
OskarEichler:codex/truncate-inspected-invalid-cron-values
Open

Preserve ArgumentError for invalid non-string cron inputs#130
OskarEichler wants to merge 1 commit into
floraison:masterfrom
OskarEichler:codex/truncate-inspected-invalid-cron-values

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

Invalid non-string cron values are inspected for an error message, but the truncation branch slices the original object. Arrays/hashes/large integers then raise unrelated TypeError/NoMethodError. Slice the inspected string instead.

Reproduction

Run after require 'fugit':

Fugit::Cron.do_parse(Array.new(20, :x))
# now ArgumentError: invalid cron string ...
# previously TypeError: no implicit conversion of String into Array

Verification

  • rbenv Ruby 4.0.6, TZ=UTC. Master baseline and this individual patch: 1,524 existing tests, 3,379 assertions, zero failures, one existing pending test.
  • 7 focused checks for this change, run outside the repository. The combined release-based branch passes 1,517 existing RSpec examples, zero failures, one pending, plus 998 focused checks.
  • Also checked the combined master changes with unmodified registry EtOrbi 1.4.1/Raabro 1.5.0: 1,524 tests/3,379 assertions, zero failures, one pending, and 997 focused checks. The extra blank-line check requires the independently fixed Raabro empty-input behavior; it is not claimed to pass on unmodified Raabro.
  • Individual/release checks used the same versions of EtOrbi/Raabro with their separately proposed fixes. Syntax and whitespace checks pass. Combined source has the same 18 pre-existing Lint warnings, with no new warnings. Release gem packaging checked.

Compatibility and limitations

Invalid input now raises the intended ArgumentError instead of accidental formatting exceptions. Error text is truncated to the existing 35-character policy.

No dependency/version upgrades, test additions or test modifications are included. The task's no-new-tests constraint was followed; reproduction/check scripts stayed outside the repository. Other Ruby versions and platforms await upstream CI. No production execution was performed. Prepared with Codex assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant