Validate natural interval steps in the correct clock fields - #133
Open
OskarEichler wants to merge 1 commit into
Open
Validate natural interval steps in the correct clock fields#133OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strict natural-interval validation reads the start of a slash expression instead of its step; */3 therefore becomes zero and valid schedules are rejected. It also relies on positions in the assembled cron fields, which shift when seconds/timezones are present. Validate the original hour/minute pair and read capture 2.
Reproduction
Run after
require 'fugit':Verification
Compatibility and limitations
Strict mode now accepts valid intervals instead of rejecting all wildcard steps. Existing hour-divisor and 1..60-minute policies are retained; this does not impose new divisibility rules on minutes or redefine seconds policy.
No dependency/version upgrades, test additions or test modifications are included. The task's no-new-tests constraint was followed; reproduction/check scripts stayed outside the repository. Other Ruby versions and platforms await upstream CI. No production execution was performed. Prepared with Codex assistance.