Make empty-duration handling explicit for parser compatibility - #135
Open
OskarEichler wants to merge 1 commit into
Open
Make empty-duration handling explicit for parser compatibility#135OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the existing empty-duration-as-zero behavior explicit in
Duration.parse, including whitespace-only input. This preserves the contract used by Rufus without depending on a parser treating a failed match as successful.This is a compatibility follow-up to floraison/raabro#13. With released Raabro 1.5.0, Fugit already returns a zero duration for empty input. With the proposed Raabro correction, that accidental acceptance disappears and Rufus's existing
parse_durationexample fails. Fugit should express its own accepted empty-duration policy.Reproduction
Using the corrected Raabro branch without this change returns nil instead.
Rufus::Scheduler.parse_duration('')then raises, contradicting the existing Rufus expectation of 0.0.Verification
Breaking changes and limitations
No intended breaking change: this preserves released behavior across the parser correction. Empty durations remain zero; invalid nonempty durations remain invalid. No dependency/version upgrades or test additions/modifications are included. Reproduction scripts stayed outside repositories under the task's no-new-tests policy. Other Ruby/platform combinations await upstream CI. No production execution. Prepared with Codex assistance.