Preserve diagnostics at newlines and unconsumed input - #14
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix error reporting in three related boundary cases:
Reproduction
A grammar requiring a literal x raises NoMethodError when parsing "xy" with error:true; it now returns a diagnostic at line 1, column 2, offset 1. A grammar requiring "x\n" followed by y reports EOF at line 2, column 1 for input "x\n".
Temporary comparisons cover an error on the first newline, an unconsumed newline, plain trailing text, EOF on an empty final line, an empty failed Tree and Unicode character offsets. Both prune:true and prune:false are checked. Existing multiline/CRLF diagnostics remain covered by the upstream suite.
Verification
No production operations. Other Ruby/platform combinations were not run locally; no full supported-platform claim. Current open/closed issue/PR searches found no overlapping fix.
Breaking changes
No intended API break; diagnostic array shape is preserved. Previously crashing paths return diagnostics, with corrected newline coordinates. Does not change parser acceptance or introduce general recovery from malformed custom Tree objects. The separate all-combinator patch addresses failed grammars incorrectly accepting empty input.