feat: add dbt manifest parsing#10
Merged
florian-drouet merged 4 commits intomainfrom May 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for parsing and caching a dbt manifest to enhance the accuracy of Tableau SQL reports by filtering columns based on your dbt models.
- Introduces a manifest cache resolver in
utils.pyfor adding, replacing, or deleting amanifest.json - Implements
DbtManifestParserto extract table names from a dbt manifest and integrates it intoTableauWorkbook - Filters reported columns in
OutputFormattingby the cached dbt table names
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tableau_sql_parser/utils.py | New resolve_manifest_path function for caching manifest |
| tableau_sql_parser/tableau_workbook.py | Accepts manifest_path, invokes DbtManifestParser |
| tableau_sql_parser/output_formatting.py | Adds filter_dbt_manifest and filters columns by manifest |
| tableau_sql_parser/dbt_manifest_parser.py | New parser class extracting dbt model/source names |
| tableau_sql_parser/cli.py | Hooks up manifest resolution and passes path to workbook |
| tableau_sql_parser/init.py | Defines APP_NAME and CACHE_FILENAME constants |
| pyproject.toml | Version bumped to 0.3.1 |
| README.md | Instructions for using the manifest cache |
Comments suppressed due to low confidence (2)
tableau_sql_parser/tableau_workbook.py:25
- The code uses
os.path.normpathbutosis not imported in this file. Addimport osat the top to avoid a NameError.
self.filename = os.path.normpath(filename)
tableau_sql_parser/dbt_manifest_parser.py:5
- There are no unit tests covering
DbtManifestParserbehaviors (loading, extraction of nodes/sources). Adding tests for both valid and missing manifest scenarios would improve confidence.
class DbtManifestParser:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.