Skip to content

Feature/migrate to ruff#5

Merged
florian-drouet merged 5 commits intomainfrom
feature/migrate-to-ruff
May 21, 2025
Merged

Feature/migrate to ruff#5
florian-drouet merged 5 commits intomainfrom
feature/migrate-to-ruff

Conversation

@florian-drouet
Copy link
Copy Markdown
Owner

No description provided.

@florian-drouet florian-drouet requested a review from Copilot May 15, 2025 18:12
@florian-drouet florian-drouet self-assigned this May 15, 2025
@florian-drouet florian-drouet added the enhancement New feature or request label May 15, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates the project to use ruff and adds type hints throughout the code while cleaning up some legacy functionality.

  • Added return and parameter type annotations in multiple test and production functions
  • Updated project metadata and configuration in pyproject.toml, CLI, and Makefile in support of the new linting and build tools
  • Revised usage instructions in the README to reflect the changes

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_tree_output.py Added a return type annotation to the test function
tests/test_recursive_search.py Added type annotations to test functions
tableau_sql_parser/utils.py Added missing return type annotation in generate_report; renamed loop variable in tree_output for clarity
tableau_sql_parser/tableau_workbook.py Updated function signatures with type hints
tableau_sql_parser/recursive_search.py Added return type annotations to class methods
tableau_sql_parser/output_formatting.py Added return type annotations to instance methods
tableau_sql_parser/cli.py Updated main function signature with type hints
pyproject.toml Migrated project metadata and new ruff configuration settings
README.md Revised usage instructions to include uv tool commands
Makefile Adjusted build steps to use uv and uvx ruff check commands
.python-version Added Python version specification
.github/workflows/python-package.yml Updated CI workflow installation and test command using uv tool

Comment thread tableau_sql_parser/utils.py
@florian-drouet florian-drouet merged commit 8c7de8f into main May 21, 2025
3 checks passed
@florian-drouet florian-drouet deleted the feature/migrate-to-ruff branch May 21, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants