Feature/migrate to ruff#5
Merged
florian-drouet merged 5 commits intomainfrom May 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the project to use ruff and adds type hints throughout the code while cleaning up some legacy functionality.
- Added return and parameter type annotations in multiple test and production functions
- Updated project metadata and configuration in pyproject.toml, CLI, and Makefile in support of the new linting and build tools
- Revised usage instructions in the README to reflect the changes
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_tree_output.py | Added a return type annotation to the test function |
| tests/test_recursive_search.py | Added type annotations to test functions |
| tableau_sql_parser/utils.py | Added missing return type annotation in generate_report; renamed loop variable in tree_output for clarity |
| tableau_sql_parser/tableau_workbook.py | Updated function signatures with type hints |
| tableau_sql_parser/recursive_search.py | Added return type annotations to class methods |
| tableau_sql_parser/output_formatting.py | Added return type annotations to instance methods |
| tableau_sql_parser/cli.py | Updated main function signature with type hints |
| pyproject.toml | Migrated project metadata and new ruff configuration settings |
| README.md | Revised usage instructions to include uv tool commands |
| Makefile | Adjusted build steps to use uv and uvx ruff check commands |
| .python-version | Added Python version specification |
| .github/workflows/python-package.yml | Updated CI workflow installation and test command using uv tool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.