Tick labelling overhaul - #136
Merged
Merged
Conversation
- also bounds the kline integrity check range for guarding possible tight loops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves axis/grid math out of the UI layer into a shared, UI-agnostic engine in
data::chart::ticks, now used by kline, comparison, heatmap, and indicator chart axes.Time axis (X):
zooming (the step whose actual spacing lands closest to the target is
picked, instead of the first one that roughly fits)
thinned to the pixel budget so long ranges stay readable
so the set of labels no longer shifts around as the view moves
Price axis (Y):
are computed in exact units (no more
f32rounding drift)