relax no-unsafe-* for src/index.ts dispatcher#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typescript-eslint/no-unsafe-*rule family forsrc/index.tsonlyunknowncasts in the proxy dispatcherWhy
The runtime proxy dispatcher receives serialized values, applies user-supplied transforms, and forwards them. Static types cannot describe that flow without defeating the purpose; the typed contract lives in generated Specta bindings, not the dispatcher. Forcing
unknown(or worse,ascasts) at the dispatch layer would just push the lint complaint around without making the runtime any safer.The
no-unsafe-*rules stay active for the rest of the codebase (taurpc Rust crate, examples, future TS code).Background
#22 introduced a per-element transform inside
Array.isArray(input)branch:Payload.event.input_typeisunknown, but TypeScript'sArray.isArraylib predicate isarg is any[], which re-widens toany[]after the guard. The?? valuethen taints the callback return toanyand trips@typescript-eslint/no-unsafe-return. That's structural; this file's job is exactly that kind of dynamic dispatch.Test plan
pnpm lint:jspasses locally withsrc/index.tsfrom Specta 2.0.0-rc.25 #22 overlaidpnpm lint:types(tsc) passesdprint checkclean on the two changed files