Fix flaky test by awaiting stream handlers in sh()#4
Merged
Conversation
Use all() instead of spawn() to ensure stdout/stderr handlers complete before returning. This prevents log message ordering races between consecutive commands.
Run stderr handler, stdout handler, and expect() concurrently with all(), ensuring all output is captured before returning. This fixes the race condition where log messages could interleave between consecutive commands.
johncarmack1984
force-pushed
the
fix-flaky-stream-handler-test
branch
from
cda9697 to
fc80c83
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all()instead ofspawn()in thesh()function to ensure stdout/stderr handlers complete before returningTest plan
complex.test.ts) 5 times consecutively with no failures