inline Position in TS exports#6
Merged
Merged
Conversation
geojson::Position would otherwise export as a named TS alias `type Position = number[]`, which collides with downstream consumers that also have a Position type (e.g. fltsci's flights_api::Position discriminated union). Mark it specta(inline) so each usage emits the inline number[] shape and the name slot stays free for the consumer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[specta(inline)]ongeojson::Positionso it doesn't export as a named TS alias.Previously the fork's specta-feature path produced
export type Position = number[];, which fights for thePositionname with downstream consumers -- in particular fltsci'sflights_api::Position(a discriminated union over Air/Ground positions). Marking Position as inline keeps the inner type override (#[specta(type = Vec<f64>)]) but renders each usage as a literalnumber[]instead of a named alias, so there's no name collision.Behavior
[lon, lat, ...]).cfg_attr(feature = "specta", ...)).Positionno longer appears as a named alias; everywhere aPositionwas referenced,number[]appears inline.Test plan
cargo build --features spectacleancargo test --features spectaclean (37 passed, 0 failed)