bufcompose now takes the source samplerate when resizing - fixes 269#300
Merged
Conversation
Member
Author
|
@weefuzzy my PR in SC is about to be merged in (famous last words) so I think we should merge that in for #269 and @rconstanzo would be happy |
weefuzzy
requested changes
Jun 13, 2025
| index nChannels{0}; | ||
| index nFrames{0}; | ||
|
|
||
| float sourceSR; |
Member
There was a problem hiding this comment.
why is this a float? just make it a double
Member
Author
|
done, compiled, and tested with the UTs in SC, including the new ones checking for SR |
weefuzzy
approved these changes
Jun 13, 2025
weefuzzy
pushed a commit
to weefuzzy/flucoma-core
that referenced
this pull request
Nov 25, 2025
…lucoma#300) * fixes 269 * scope! * amended the resolution of the sourceSR variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.