Fix/trigger output logic#309
Merged
Merged
Conversation
# Conflicts: # include/flucoma/clients/nrt/KNNRegressorClient.hpp
Member
|
Looked at this quickly the other day and didn't respond, but yes, this is wise. Thank you! |
Member
Author
|
thanks it's merged and now the nightlies have them - feel free to road test! |
Member
|
will do but after my gigs this week |
weefuzzy
pushed a commit
to weefuzzy/flucoma-core
that referenced
this pull request
Nov 25, 2025
* trigger output logic - outputs 1 only if successful query * change post inconsistency fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the logic of the trigger output of the KR objects.
Instead of copying the input to the output, we now output 0 except in the block where the kr action will have been successful. If the process function bails, it will give the user nothing, which is a good way to troubleshoot and in line with trigger chaining.