Skip to content

loudness: fix crash-inducing min requirement for winsize #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tremblap merged 1 commit into from
Aug 18, 2025
Merged

loudness: fix crash-inducing min requirement for winsize #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/flucoma/clients/rt/LoudnessClient.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ constexpr auto LoudnessParams = defineParameters(
ChoicesParam("select","Selection of Outputs","loudness","peak"),
EnumParam("kWeighting", "Apply K-Weighting", 1, "Off", "On"),
EnumParam("truePeak", "Compute True Peak", 1, "Off", "On"),
LongParam("windowSize", "Window Size", 1024, UpperLimit<kMaxWindowSize>()),
LongParam("windowSize", "Window Size", 1024, Min(1),
UpperLimit<kMaxWindowSize>()),
LongParam("hopSize", "Hop Size", 512, Min(1)),
LongParam<Fixed<true>>("maxWindowSize", "Max Window Size", 16384, Min(4),
PowerOfTwo{}, Max(32768)) // 17640 next power of two
Expand Down
Loading