fix: support object for httpUser and httpPassword in fluentbit ES output#620
Open
rezNetDevOps wants to merge 1 commit intofluent:mainfrom
Open
fix: support object for httpUser and httpPassword in fluentbit ES output#620rezNetDevOps wants to merge 1 commit intofluent:mainfrom
rezNetDevOps wants to merge 1 commit intofluent:mainfrom
Conversation
Signed-off-by: Rez <mrreza.com@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the fluent-operator Helm chart to support both string and object values for the
httpUserandhttpPasswordfields in the Elasticsearch output. This is required for compatibility with recent CRDs that expect these fields to be objects when using secret references.Why is it needed?
Currently, the template always renders these fields as strings, which causes CRD validation errors when an object is required (e.g., for secret references). This change adds logic to render the value as an object if a map is provided, or as a string otherwise, for backward compatibility.
How to test
httpUser/httpPasswordinvalues.yaml:helm templateand verify the rendered manifest contains the object, not a string.Related issues
Signed-off-by
This PR is signed off in accordance with the DCO.
Let me know if you need any more info or want me to add tests!